Review: Needs Fixing

5       self.background_audio = []
6       self.theme_overwritten = False
7       self.temporary_edit = False
8       + self.AutoPlaySlidesOnce = False
9       + self.AutoPlaySlidesLoop = False
10      + self.TimedSlideInterval = 0

If you compare the names of your variables to the ones above yours, they are 
different. Please change yours to look the same.


16      u'search': self.search_string,
17      u'data': self.data_string,
18      u'xml_version': self.xml_version,
19      + u'AutoPlaySlidesOnce': self.AutoPlaySlidesOnce,
20      + u'AutoPlaySlidesLoop': self.AutoPlaySlidesLoop,
21      + u'TimedSlideInterval': self.TimedSlideInterval,

If you look at the strings above yours, they are different to the way yours are 
formatted. Please change yours to look the same.

Almost all of your variables are incorrectly formatted. Please make sure you 
know the difference between a pure Python class and a Qt-derived class.
-- 
https://code.launchpad.net/~marmyshev/openlp/autoplay/+merge/133739
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to