Review: Needs Fixing
Just going over the tests, you seem to be getting the hang of it. One small
thing I've picked up so far...
582 + assert service_item.is_valid is True, u'A valid Service Item'
583 + assert service_item.missing_frames() is True, u'No frames loaded yet'
The message set in the assert statement should detail why the assert failed,
were it to fail. So, in the case of the two lines above, you want to rather
write something like this:
assert service_item.is_valid is True, u'The new service item should be
valid'
assert service_item.missing_frames() is True, u'There should not be any
frames in the service item'
Your GIVEN, WHEN and THEN comments need a space between the # and the word.
642 + #When requesting a saved service item
You have a couple of "When" and "Then" comments which don't match the others
There are also a couple of "assert ... is <integer>" which should really be ==.
--
https://code.launchpad.net/~trb143/openlp/media/+merge/143988
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
