Review: Needs Fixing Usability Review - Text font for Imported is too small - Was it a design feature not to allow children on imported or dropped on. - Import works fine. - Add new child works so does DND. Focus should be changed to the dropped leaf though. - Unable to scroll with a drag. Try dragging over a screen full and it is impossible to move to a leaf. Maybe drop anywhere and add to that leaf.
Code Review loadFile DNDInternal etc should be load_file and DnD_internal. New variables should follow this standard. Do not use file for a variable file_images is OK. 420 / 1476 far too long a line. 420-426 why are we eventing we should do not need to. new dialogs should have under_score names not camelCase names. 1519 space round = 1884 - new line why -- https://code.launchpad.net/~arjan-i/openlp/images_groups/+merge/145368 Your team OpenLP Core is requested to review the proposed merge of lp:~arjan-i/openlp/images_groups into lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
