Review: Needs Fixing

Noticed this in a few other files too...

23      +import os
24      +
25      +from unittest import TestCase
26      +
27      +from openlp.core.lib import Registry, ImageManager, ScreenList
28      +from PyQt4 import QtGui

Your import order is incorrect, it should be: 1. stdlib, 2. 3rd party, 3. 
project.

  import os
  from unittest import TestCase

  fromPyQt4 import QtGui

  from openlp.core.lib import Registry, ImageManager, ScreenList


-- 
https://code.launchpad.net/~trb143/openlp/tests_only/+merge/148517
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to