Review: Needs Fixing

Missed one (or two):

3460    + self.portLabel = QtGui.QLabel(self.server_settings_group_box)
3584    + ipAddress = self.address_edit.text()

Is there a reason these haven't been refactored?

- serviceItem
- self.serviceItem
- self.currentMediaPlayer
- self.displayControllers

-- 
https://code.launchpad.net/~trb143/openlp/cleanup-plugins/+merge/151803
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to