299     + if len(windows) == 0:
302     + if len(slideshows) == 0:
> Just do "if my_list"

windows could be not "None" but could has 0 items and "if windows:" returns 
true - because of appscript reference.

550-560 - I still didnt decide how to solve the probleme of changing settins by 
user. This is in progress.

607-613: PPT for mac when you save slides as PNG creates dir for slides with 
same name as file name if the full path of presentation contains non-latin 
symbols. Probably it's not needed to log, but the algorithm support current 
work of MS PPT.

837-842: I dont know why this subs are exist in controllers for Windows PPT. I 
just added the same for support. I didnt find any references to this in other 
code.

913-915: is needed for setting up values for Keynote. this is because Core devs 
has changes Settins() system. I need this just in keynotecontroller, may be you 
could advise how to place it there and append to __default_settings__ of the 
plugin? I will need to append some setting keys with the same way in 
pptmaccontroller.

Agree with all other comments to my code. Will fix it soon.
-- 
https://code.launchpad.net/~marmyshev/openlp/presentation/+merge/156713
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to