Andreas Preikschat has proposed merging lp:~googol/openlp/bug-1164925 into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
Related bugs:
Bug #1164925 in OpenLP: "Separate blank buttons don't hide on resizing"
https://bugs.launchpad.net/openlp/+bug/1164925
For more details, see:
https://code.launchpad.net/~googol/openlp/bug-1164925/+merge/157370
Hello,
- reduced threshold for "separate blank button" (bug #1164925)
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Functional_Tests/77/console
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Interface_Tests/23/console
--
https://code.launchpad.net/~googol/openlp/bug-1164925/+merge/157370
Your team OpenLP Core is subscribed to branch lp:openlp.
=== modified file 'openlp/core/ui/slidecontroller.py'
--- openlp/core/ui/slidecontroller.py 2013-03-26 07:34:42 +0000
+++ openlp/core/ui/slidecontroller.py 2013-04-05 14:07:25 +0000
@@ -44,6 +44,8 @@
log = logging.getLogger(__name__)
+# Threshold which has to be trespassed to toggle.
+HIDE_MENU_THRESHOLD = 27
AUDIO_TIME_LABEL_STYLESHEET = u'background-color: palette(background); ' \
u'border-top-color: palette(shadow); ' \
u'border-left-color: palette(shadow); ' \
@@ -588,12 +590,12 @@
if self.is_live:
# Space used by the toolbar.
used_space = self.toolbar.size().width() + self.hide_menu.size().width()
- # The + 40 is needed to prevent flickering. This can be considered a "buffer".
- if width > used_space + 40 and self.hide_menu.isVisible():
+ # Add the threshold to prevent flickering.
+ if width > used_space + HIDE_MENU_THRESHOLD and self.hide_menu.isVisible():
self.toolbar.set_widget_visible(self.narrow_menu, False)
self.toolbar.set_widget_visible(self.wide_menu)
- # The - 40 is needed to prevent flickering. This can be considered a "buffer".
- elif width < used_space - 40 and not self.hide_menu.isVisible():
+ # Take away a threshold to prevent flickering.
+ elif width < used_space - HIDE_MENU_THRESHOLD and not self.hide_menu.isVisible():
self.toolbar.set_widget_visible(self.wide_menu, False)
self.toolbar.set_widget_visible(self.narrow_menu)
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
