Review: Needs Fixing

104     + size = self._getFileSize(u'%s%s/%s' % (self.baseurl, bibles_dir, 
filename))

I know this works, by technically one should use urlparse.urljoin:

    http://docs.python.org/2/library/urlparse.html#urlparse.urljoin
-- 
https://code.launchpad.net/~mzibricky/openlp/bug-1160506_2.0/+merge/157486
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to