Review: Needs Fixing

    def sha_password_encrypter(password):

Try as I might, I can't let this pass... this is not encryption, it is just 
hashing. encryption means you should be able to decrypt it, which you can't 
with sha. Please rename to "make_sha_hash" or something.
-- 
https://code.launchpad.net/~trb143/openlp/cherrypy/+merge/157468
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to