Review: Needs Fixing 33 +""" 34 +The :mod:`slidecontroller` module contains the most important part of OpenLP - the slide controller 35 +"""
Lines 43, 153 and 150: docstring missing. Even when you are reimplementing a method (which I assume you do) you should have docstrings (for example mentioning that you are reimplementing a method). 145 + #Scroll to next item if possible. Missing space: # Scroll You have to add some test cases. Otherwise good idea to refactor some code. :) -- https://code.launchpad.net/~patrick-zakweb/openlp/image-previews/+merge/160207 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
