Review: Needs Fixing

One minor detail in your tests. You have a helper method which is public. It 
would be better if it were "private" and thus starts with an underscore:

  def recursively_delete_group_side_effect(*args, **kwargs)

becomes

  def _recursively_delete_group_side_effect(*args, **kwargs)
-- 
https://code.launchpad.net/~arjan-i/openlp/images_groups_bugfix/+merge/163731
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to