Review: Needs Fixing
50 + self.is_verse_number_visible = False
51 + # We have a set value convert to True/False.
52 + if check_state == QtCore.Qt.Checked:
53 + self.is_verse_number_visible = True
You can simply do:
self.is_verse_number_visible = check_state == QtCore.Qt.Checked
or
self.is_verse_number_visible = (check_state == QtCore.Qt.Checked)
And please create a bug report and target it to the documentation series (just
click "Target to series" and select "documentation" after creating the bug). It
should be done for the documenters, so that they know they have to update the
manual.
Rest is OK! Nice!
--
https://code.launchpad.net/~oliwee/openlp/HideBibleVerses/+merge/184419
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
