Review: Needs Fixing I've not been able to test this myself yet, but there are a few small things which need changing.
Can you add the copyright/license info at the top of test_songbeamerimport.py Line 56: Raoul recently changed the way we import MagicMock and patch, so you're going to need to merge trunk and then fix your imports so they look like: http://bazaar.launchpad.net/~openlp-core/openlp/trunk/view/head:/tests/functional/openlp_plugins/songs/test_ewimport.py#L36 Line 60: Can you change this to: http://bazaar.launchpad.net/~openlp-core/openlp/trunk/view/head:/tests/functional/openlp_plugins/songs/test_ewimport.py#L40 -- https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+merge/189514 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
