Review: Approve

945     + plugin.get_display_css = MagicMock(return_value='plugin CSS')
946     + plugin.get_display_javascript = MagicMock(return_value='plugin JS')
947     + plugin.get_display_html = MagicMock(return_value='plugin HTML')

While this is not wrong, what you can also do is: 

    plugin.get_display_css.return_value = 'plugin CSS'
-- 
https://code.launchpad.net/~googol/openlp/html-clean-up/+merge/190593
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to