Review: Needs Fixing

66      + except Exception as e:
67      + if log.getEffectiveLevel() <= logging.ERROR:
68      + log.error('Exception in %s : %s' % (func.__name__, e))

This is going to catch all exceptions, and will cause problems when we need 
exceptions to bubble up. Reraise the exception.
-- 
https://code.launchpad.net/~trb143/openlp/refactor/+merge/192825
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to