1. I agree, I will move it to a constant (I tried to declare it as a constant of the class but it didn't let me, apparently this is a special class that extends HttpBase... in a special way), but I will read on module constant and apply. 2. I disagree, this is the unit test for this method, and this method will be called with OS specific paths and I think it should be tested for them. Please comment. -- https://code.launchpad.net/~felipe-q/openlp/fix_httprouter/+merge/194569 Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
