> The events are different. Why move to emit() ?

Because the way we've been doing threads up till now in Qt has been wrong. The 
only way to get data from a thread worker to the main application in Qt is via 
signals and slots, hence the emits.

> self.main_window.application.process_events() Why not use application 
> directly.

Done.

> HistoryComboBox should be in common not lib.

Done.

> 2468 extra blank line

Done.
-- 
https://code.launchpad.net/~raoul-snyman/openlp/songselect2/+merge/209792
Your team OpenLP Core is subscribed to branch lp:openlp.

_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help   : https://help.launchpad.net/ListHelp

Reply via email to