Review: Needs Information
Please run the tests (you can use the script in
trunk/scripts/jenkins_script.py). This is always needed (even tough you just
added a test). This is because we also have a job which tests if your code is
pep8 compliant).
Otherwise you consider this APPROVED.
A side note:
You could change line 72,75-77:
tags = [line.decode('utf-8').split() for line in stdout.splitlines()]
or (if you prefer less "things" to be done in one line):
lines = [line.decode('utf-8') for line in stdout.splitlines()]
tags = list(map(str.split, lines))
Regards
--
https://code.launchpad.net/~springermac/openlp/bzr-tag-test/+merge/214467
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
