Review: Needs Fixing
Didn't test this, but some notes from a quick look:
I guess we don't need all these log.debug('function_name').
285+286: except should specify Exception type. Also return is better than pass.
There are at least two more except without a type.
350+351: What is this?
396, 411: TODO
435: Fixme. The code doesn't look very efficient.
580: Reference to Keynote.
Tests: I guess we should use self.assert...() instead of the assert keyword.
--
https://code.launchpad.net/~raoul-snyman/openlp/powerpointmac/+merge/220530
Your team OpenLP Core is requested to review the proposed merge of
lp:~raoul-snyman/openlp/powerpointmac into lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
