Review: Needs Fixing
You are adding code with no use case for now. I assume this is for Network
changes in 2.4 but no new code.
Confused by test.
In code you call Foo(x,y).encode('ascii')
in test you call foo(x.encode('ascii'), y.encode('ascii))
A test to support the non ascii would be nice.
--
https://code.launchpad.net/~alisonken1/openlp/hash_fix/+merge/248460
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
