Review: Approve I would rather call the hash you read in something like "hash" or "file_hash". The "sha256" gets really confusing, especially to someone like me who has used the hashing functions a fair amount, and I think you're using the hashing function, but then it's not right, etc.
Other than that, this looks OK to me. -- https://code.launchpad.net/~phill-ridout/openlp/bug1073931/+merge/249720 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
