Review: Needs Fixing
Diff comments:
>
> === modified file 'openlp/plugins/media/lib/mediaitem.py'
> --- openlp/plugins/media/lib/mediaitem.py 2015-05-28 20:38:43 +0000
> +++ openlp/plugins/media/lib/mediaitem.py 2015-09-09 01:53:53 +0000
> @@ -130,7 +129,8 @@
> optical_button_text = translate('MediaPlugin.MediaItem', 'Load
> CD/DVD')
> optical_button_tooltip = translate('MediaPlugin.MediaItem',
> 'Load CD/DVD - only supported
> when VLC is installed and enabled')
> - self.load_optical = self.toolbar.add_toolbar_action('load_optical',
> icon=OPTICAL_ICON, text=optical_button_text,
> + self.load_optical = self.toolbar.add_toolbar_action('load_optical',
> icon=build_icon(OPTICAL),
These were static to stop the icon generation each time used. Can they be
generated on the constructure and then referenced by self. as a compromise.
> +
> text=optical_button_text,
>
> tooltip=optical_button_tooltip,
>
> triggers=self.on_load_optical)
> if disable_optical_button_text:
--
https://code.launchpad.net/~springermac/openlp/api-documentation-fixes/+merge/270472
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
