Review: Needs Fixing
1. When I tried to use live-background, the video did show, but it was in the
foreground and I could not make OpenLP show the song text again.
2. When I tried playing media without overwriting the player I got the
traceback below, but it works fine if I chose to overwrite the players.
Traceback (most recent call last):
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/lib/mediamanageritem.py",
line 500, in on_live_click
self.go_live()
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/lib/mediamanageritem.py",
line 527, in go_live
self.live_controller.add_service_item(service_item)
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/common/openlpmixin.py",
line 58, in wrapped
raise e
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/common/openlpmixin.py",
line 54, in wrapped
return func(*args, **kwargs)
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/ui/slidecontroller.py",
line 779, in add_service_item
self._process_item(item, slide_no)
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/ui/slidecontroller.py",
line 896, in _process_item
self.on_media_start(service_item)
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/common/openlpmixin.py",
line 58, in wrapped
raise e
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/common/openlpmixin.py",
line 54, in wrapped
return func(*args, **kwargs)
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/ui/slidecontroller.py",
line 1362, in on_media_start
self.media_controller.video(self.controller_type, item, self.hide_mode())
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/common/openlpmixin.py",
line 58, in wrapped
raise e
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/common/openlpmixin.py",
line 54, in wrapped
return func(*args, **kwargs)
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/ui/media/mediacontroller.py",
line 376, in video
is_valid = self._check_file_type(controller, display, service_item)
File
"/home/tgc/projects/OpenLP/code/pyqt5_final/openlp/core/ui/media/mediacontroller.py",
line 533, in _check_file_type
player = self.media_players[title]
TypeError: unhashable type: 'list'
--
https://code.launchpad.net/~springermac/openlp/pyqt5_final/+merge/279200
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
