Review: Needs Fixing I like it. Just fix up the small things I highlighted, and then let's get it in!
Diff comments: > > === modified file 'openlp/core/ui/shortcutlistdialog.py' > --- openlp/core/ui/shortcutlistdialog.py 2015-11-07 00:49:40 +0000 > +++ openlp/core/ui/shortcutlistdialog.py 2015-12-24 04:28:48 +0000 > @@ -50,6 +50,14 @@ > event.ignore() > > > +class ShortcutTreeWidget(QtWidgets.QTreeWidget): > + def __init__(self, *args): > + super(ShortcutTreeWidget, self).__init__(*args) > + > + def keyboardSearch(self, search): This should have a docstring. > + pass If this method should be implemented by child classes, rather raise a NotImplementedError so that programmers won't miss it by mistake. > + > + > class Ui_ShortcutListDialog(object): > """ > The UI widgets for the shortcut dialog. -- https://code.launchpad.net/~springermac/openlp/keyboard_shortcuts/+merge/281337 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
