Review: Needs Fixing
Hum not sure about this, I had a lot of issues stopping and starting the
server with OpenLP running and blocked threads.
Toggling the active / inactive 3 times produced this
Traceback (most recent call last):
File "/home/tim/Projects/openlp/fix-remote/openlp/core/ui/pluginform.py",
line 140, in on_status_combo_box_changed
self.active_plugin.toggle_status(PluginStatus.Inactive)
File "/home/tim/Projects/openlp/fix-remote/openlp/core/lib/plugin.py", line
188, in toggle_status
self.finalise()
File
"/home/tim/Projects/openlp/fix-remote/openlp/plugins/remotes/remoteplugin.py",
line 88, in finalise
self.server.stop_server()
File
"/home/tim/Projects/openlp/fix-remote/openlp/plugins/remotes/lib/httpserver.py",
line 151, in stop_server
self.httpd.shutdown()
AttributeError: 'OpenLPServer' object has no attribute 'httpd'
This failed to close the server cleanly and lead to this error.
2016-01-14 21:17:06,985 openlp.plugins.remotes.lib.httpserver
DEBUG Initialise OpenLP
2016-01-14 21:17:06,991 openlp.core.OpenLP
DEBUG Entering set_normal_cursor
2016-01-14 21:17:06,991 openlp.plugins.remotes.lib.httpserver
DEBUG failed to start http server thread state 1 True with error [Errno 98]
Address already in use
2016-01-14 21:17:07,093 openlp.plugins.remotes.lib.httpserver
DEBUG failed to start http server thread state 2 True with error [Errno 98]
Address already in use
2016-01-14 21:17:07,193 openlp.plugins.remotes.lib.httpserver
DEBUG failed to start http server thread state 3 True with error [Errno 98]
Address already in use
2016-01-14 21:17:07,294 openlp.plugins.remotes.lib.httpserver
DEBUG Failed to start server
In the settings the change from non-ssl to ssl asks the user to restart openlp.
This may be a safer option as now I would need to restart openlp to free the
port.
--
https://code.launchpad.net/~thelinuxguy/openlp/fix-remote/+merge/282447
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
