Review: Needs Information See my inline comment.
Diff comments: > === modified file 'openlp/core/lib/settingstab.py' > --- openlp/core/lib/settingstab.py 2015-12-31 22:46:06 +0000 > +++ openlp/core/lib/settingstab.py 2016-03-29 17:09:30 +0000 > @@ -135,4 +135,4 @@ > """ > Tab has just been made visible to the user > """ > - self.tab_visited = True > + pass If you're just going to "pass" can't you remove the method completely? Or what is it here for? If it should be implemented by a plugin, then rather raise a NotImplementedError. -- https://code.launchpad.net/~trb143/openlp/themefixes/+merge/290340 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
