Review: Needs Fixing
Far to complex to translate and britle needs to be refactored to something
simpler.
Diff comments:
> === modified file 'openlp/core/common/uistrings.py'
> --- openlp/core/common/uistrings.py 2016-01-23 08:15:37 +0000
> +++ openlp/core/common/uistrings.py 2016-04-03 20:59:16 +0000
> @@ -151,3 +151,22 @@
> self.Version = translate('OpenLP.Ui', 'Version')
> self.View = translate('OpenLP.Ui', 'View')
> self.ViewMode = translate('OpenLP.Ui', 'View Mode')
> + self.BibleShortSearchTitle = translate('OpenLP.Ui', 'Search is Empty
> or too Short')
> + self.BibleScriptureError = translate('OpenLP.Ui', '<br><br>Book
> Chapter | John 3:16<br>'
This needs to be broken down into vers small bits which cannot be broken. Look
at the about ui for a example.
> + 'Book
> Chapter%(range)sChapter | John 3%(range)s4<br>'
> + 'Book
> Chapter%(verse)sVerse%(range)sVerse | John 3%(verse)'
> +
> 's16%(range)s17<br>Book Chapter%(verse)sVerse%(range)sVerse%'
> +
> '(list)sVerse%(range)sVerse | John 3%(verse)s16-17%(list)s20%'
> +
> '(range)s22<br>Book Chapter%(verse)sVerse%(range)sVerse%'
> +
> '(list)sChapter%(verse)sVerse%(range)sVerse | John 3%(verse)'
> +
> 's16%(range)s17%(list)s5%(verse)s7%(range)s9<br>Book Chapter%'
> +
> '(verse)sVerse%(range)sChapter%(verse)sVerse | John 3%(verse)'
> +
> 's16%(range)s4%(verse)s2<br><br> Book names may be shortened '
> + 'from full names,
> for an example: Joh 3 = John 3',
> + 'Please pay attention to the
> appended "s" of the wildcards and refrain '
> + 'from translating the words
> inside the names in the brackets.')
> + self.BibleShortSearch = translate('OpenLP.Ui', '<strong>The search
> you have entered is empty or shorter '
> + 'than 3 characters
> long.<br>Please try again with '
> + 'a longer
> search.</strong><br><br>You can separate different '
> + 'keywords by a space
> to search for all of your keywords and you '
> + 'can separate them by
> a comma to search for one of them.')
--
https://code.launchpad.net/~suutari-olli/openlp/combined-bible-quick-search/+merge/290839
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
