Review: Needs Fixing
Check my comment. I'll try to look at this more in-depth over the weekend and
give you more feedback.
Diff comments:
>
> === modified file 'openlp/core/lib/mediamanageritem.py'
> --- openlp/core/lib/mediamanageritem.py 2016-04-03 19:12:37 +0000
> +++ openlp/core/lib/mediamanageritem.py 2016-04-20 16:13:53 +0000
> @@ -481,6 +481,9 @@
> 'You must select one
> or more items to preview.'))
> else:
> log.debug('%s Preview requested' % self.plugin.name)
> + # If ('advanced/double click live') is not enabled, double
> clicking preview adds the item to Service.
> + # This setting prevents it from being sent to Service multiple
> times, in here it is reset to False.
> + Settings().setValue('core/has doubleclicking preview added item
> to service', False)
I don't think this is the right way to do it. I feel there's a better way for a
temporary flag than the settings file. What happens if OpenLP crashes before
the flag has been set back?
> service_item = self.build_service_item()
> if service_item:
> service_item.from_plugin = True
--
https://code.launchpad.net/~suutari-olli/openlp/click-slide-to-go-live-from-blank/+merge/292407
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
