Review: Needs Fixing
One error I think
Hvae you tested the bibles as playing with the regex is brave!
Diff comments:
> === modified file 'openlp/core/__init__.py'
> --- openlp/core/__init__.py 2016-04-04 19:53:54 +0000
> +++ openlp/core/__init__.py 2016-04-23 20:14:04 +0000
> @@ -222,10 +222,11 @@
> QtWidgets.QMessageBox.warning(None, translate('OpenLP',
> 'Backup'),
> translate('OpenLP',
> 'Backup of the data folder failed!'))
> return
> - QtWidgets.QMessageBox.information(None, translate('OpenLP',
> 'Backup'),
> - translate('OpenLP',
> - 'A backup of the
> data folder has been created at %s')
> - % data_folder_backup_path)
> + message = translate('OpenLP',
> + 'A backup of the data folder has been
> created'
> + 'at
> {text}'.format(text=data_folder_backup_path))
Is this correct as the .format would be translated?
> + QtWidgets.QMessageBox.information(None, translate('OpenLP',
> 'Backup'), message)
> +
> # Update the version in the settings
> Settings().setValue('core/application version', openlp_version)
>
--
https://code.launchpad.net/~alisonken1/openlp/strings_init/+merge/292717
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
