Review: Needs Fixing
See below and tests would be nice.
Diff comments:
>
> === modified file 'openlp/core/ui/shortcutlistform.py'
> --- openlp/core/ui/shortcutlistform.py 2016-05-20 16:22:06 +0000
> +++ openlp/core/ui/shortcutlistform.py 2016-08-14 21:23:25 +0000
> @@ -430,7 +430,8 @@
> ' use a different shortcut.'
>
> ).format(key=self.get_shortcut_string(key_sequence))
>
> self.main_window.warning_message(translate('OpenLP.ShortcutListDialog',
> 'Duplicate Shortcut'),
> - text, for_display=True)
Please leave this as it is used by Remote to stop error messages being
displayed.
> + text)
> + for_display = True
> self.dialog_was_shown = True
> return is_valid
>
--
https://code.launchpad.net/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc/+merge/302896
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
