Review: Needs Fixing
Diff comments:
>
> === modified file 'tests/functional/openlp_core_ui/test_servicemanager.py'
> --- tests/functional/openlp_core_ui/test_servicemanager.py 2016-09-19
> 18:51:48 +0000
> +++ tests/functional/openlp_core_ui/test_servicemanager.py 2016-11-01
> 07:01:03 +0000
> @@ -545,8 +545,8 @@
>
> self.assertEqual(service_manager.theme_menu.menuAction().setVisible.call_count,
> 1,
> 'Should have be called once')
>
> - @patch('openlp.core.ui.servicemanager.Settings')
> - @patch('PyQt5.QtCore.QTimer.singleShot')
> + @patch(u'openlp.core.ui.servicemanager.Settings')
> + @patch(u'PyQt5.QtCore.QTimer.singleShot')
Wh are you adding the u in when you made me talk them out?
> def test_single_click_preview_true(self, mocked_singleShot,
> MockedSettings):
> """
> Test that when "Preview items when clicked in Service Manager"
> enabled the preview timer starts
--
https://code.launchpad.net/~phill-ridout/openlp/bug1623711/+merge/309724
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
