Review: Needs Fixing
See inline
Diff comments:
> === modified file 'openlp/core/lib/projector/pjlink.py'
> --- openlp/core/lib/projector/pjlink.py 2017-08-11 11:04:33 +0000
> +++ openlp/core/lib/projector/pjlink.py 2017-08-12 10:38:14 +0000
> @@ -467,7 +467,11 @@
> """
> Software version of projector
> """
> - if self.sw_version is None:
> + if len(data) > 32:
> + # Defined in specs max version is 32 characters
> + log.warn("Invalid software version - too long")
warn is deprecated so please use warning.
> + return
> + elif self.sw_version is None:
> log.debug("({ip}) Setting projector software version to
> '{data}'".format(ip=self.ip, data=data))
> self.sw_version = data
> self.db_update = True
--
https://code.launchpad.net/~alisonken1/openlp/pjlink2-i/+merge/328949
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
