Review: Needs Information
Diff comments:
> === modified file 'openlp/core/__init__.py'
> --- openlp/core/__init__.py 2017-08-01 20:59:41 +0000
> +++ openlp/core/__init__.py 2017-08-12 19:11:29 +0000
> @@ -391,7 +395,7 @@
> Settings.setDefaultFormat(Settings.IniFormat)
> # Get location OpenLPPortable.ini
> application_path = str(AppLocation.get_directory(AppLocation.AppDir))
> - set_up_logging(os.path.abspath(os.path.join(application_path, '..',
> '..', 'Other')))
> + set_up_logging(Path(os.path.abspath(os.path.join(application_path,
> '..', '..', 'Other'))))
Excuse my ignorance, but why are you still using os.path in there?
> log.info('Running portable')
> portable_settings_file =
> os.path.abspath(os.path.join(application_path, '..', '..', 'Data',
> 'OpenLP.ini'))
> # Make this our settings file
--
https://code.launchpad.net/~phill-ridout/openlp/pathlib3/+merge/328950
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
