Review: Needs Fixing
A couple of fixes I missed the first time
Diff comments:
>
> === modified file 'openlp/core/ui/slidecontroller.py'
> --- openlp/core/ui/slidecontroller.py 2018-02-03 11:32:49 +0000
> +++ openlp/core/ui/slidecontroller.py 2018-03-16 20:48:40 +0000
> @@ -1381,6 +1387,14 @@
> if new_item:
> self.add_service_item(new_item)
>
> + def on_clear(self):
> + """
> + Clear the preview bar.
> + """
> + self.preview_widget.clear_list()
> + self.toolbar.set_widget_visible('editSong', False)
> + self.toolbar.set_widget_visible('"clear', False)
I think you accidentally left the " in
> +
> def on_preview_add_to_service(self):
> """
> From the preview display request the Item to be added to service
>
> === modified file 'openlp/plugins/custom/lib/mediaitem.py'
> --- openlp/plugins/custom/lib/mediaitem.py 2017-12-29 09:15:48 +0000
> +++ openlp/plugins/custom/lib/mediaitem.py 2018-03-16 20:48:40 +0000
> @@ -243,6 +250,23 @@
> service_item.raw_footer.append('')
> return True
>
> + def on_clone_click(self):
> + """
> + Clone the selected Custom item
> + """
> + item = self.list_view.currentItem()
> + item_id = item.data(QtCore.Qt.UserRole)
> + old_custom_slide = self.plugin.db_manager.get_object(CustomSlide,
> item_id)
> + new_custom_slide = CustomSlide()
> + new_custom_slide.title = '{title}
> <{text}>'.format(title=old_custom_slide.title,
> +
> text=translate('SongsPlugin.MediaItem',
This is not the songs plugin
> +
> 'copy', 'For song cloning'))
Ditto
> + new_custom_slide.text = old_custom_slide.text
> + new_custom_slide.credits = old_custom_slide.credits
> + new_custom_slide.theme_name = old_custom_slide.theme_name
> + self.plugin.db_manager.save_object(new_custom_slide)
> + self.on_search_text_button_clicked()
> +
> def on_search_text_button_clicked(self):
> """
> Search the plugin database
--
https://code.launchpad.net/~trb143/openlp/cleanups02182/+merge/341547
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
