Review: Needs Fixing I highlighted some minor things with diff-comments. Also you should not add more changes to this merge requests: It is starting to become to broad.
Diff comments: > === renamed file 'openlp.py' => 'openlp/__main__.py' As mentioned in mailinglist thread linked to above, it was agreed that the renamed file should be "run_openlp.py", please do that instead of __main__.py > > === modified file 'tests/README.txt' > --- tests/README.txt 2012-12-05 18:52:31 +0000 > +++ tests/README.txt 2018-10-16 19:07:47 +0000 > @@ -19,16 +19,16 @@ > > To run the tests, navigate to the root directory of the OpenLP project, and > then run the following command:: > > - nosetests -v tests > + nose2 -v tests > > Or, to run only the functional tests, run the following command:: > > - nosetests -v tests/functional > + nose2 -v tests.functional > > Or, to run only a particular test suite within a file, run the following > command:: > > - nosetests -v tests/functional/test_applocation.py > + nose2 -v tests.functional.openlp_core.test_app > > Finally, to only run a particular test, run the following command:: > > - nosetests -v > tests/functional/test_applocation.py:TestAppLocation.get_frozen_path_test > + nose2 -v > tests.functional.openlp_core.test_app.TestOpenLP.test_process_events pytest is actually the preferred test runner now, so if updating the examples they should should use pytest. -- https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356801 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
