Review: Needs Information I assume the commented out code is a work in progress?
L7027: if statement not needed L7953: I'm not convinced the user will want to see a dialog box every time the preview, go live, or edit a song that has audio.... Also it looks like you've removed the background audio controls from the live slide controller, but not replaced them with anything? -- https://code.launchpad.net/~trb143/openlp/media_state/+merge/361389 Your team OpenLP Core is subscribed to branch lp:openlp. _______________________________________________ Mailing list: https://launchpad.net/~openlp-core Post to : [email protected] Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
