Review: Needs Fixing
A few comments below. Will try to test on a few systems later.
Diff comments:
>
> === modified file 'openlp/core/ui/generaltab.py'
> --- openlp/core/ui/generaltab.py 2019-03-16 10:20:46 +0000
> +++ openlp/core/ui/generaltab.py 2019-04-21 12:51:38 +0000
> @@ -113,6 +113,9 @@
> self.check_for_updates_check_box =
> QtWidgets.QCheckBox(self.startup_group_box)
>
> self.check_for_updates_check_box.setObjectName('check_for_updates_check_box')
> self.startup_layout.addWidget(self.check_for_updates_check_box)
> + self.experimental_check_box =
> QtWidgets.QCheckBox(self.startup_group_box)
> + self.experimental_check_box.setObjectName('experimental_check_box')
> + self.startup_layout.addWidget(self.experimental_check_box)
> self.right_layout.addWidget(self.startup_group_box)
Wouldn't it make more sense to have the experimental thing on the advanced tab?
> # Logo
> self.logo_group_box = QtWidgets.QGroupBox(self.right_column)
>
> === modified file 'openlp/core/ui/media/mediatab.py'
> --- openlp/core/ui/media/mediatab.py 2019-04-09 17:32:10 +0000
> +++ openlp/core/ui/media/mediatab.py 2019-04-21 12:51:38 +0000
> @@ -100,6 +108,20 @@
> self.stream_edit.setPlainText(LINUX_STREAM)
> elif is_win:
> self.stream_edit.setPlainText(WIN_STREAM)
> + else:
> + self.stream_edit.setPlainText(OSX_STREAM)
> +
> self.vlc_additions_edit.setPlainText(Settings().value(self.settings_section +
> '/vlc additions'))
> + if Settings().value('core/experimental'):
> + print('Video input:')
> + for cam in QCameraInfo.availableCameras():
> + print('===============')
> + print(cam.deviceName())
> + print(cam.description())
> + print()
> + print('Audio input:')
> + for au in QAudioDeviceInfo.availableDevices(QAudio.AudioInput):
> + print('===============')
> + print(au.deviceName())
Remove prints, or put in debug log
>
> def save(self):
> """
--
https://code.launchpad.net/~trb143/openlp/more_media/+merge/366336
Your team OpenLP Core is subscribed to branch lp:openlp.
_______________________________________________
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openlp-core
More help : https://help.launchpad.net/ListHelp
