[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259372#comment-13259372
 ] 

Maxim Solodovnik commented on OPENMEETINGS-194:
-----------------------------------------------

Hello Dmitry,

I like the patch.
There only 1 thing I would like to change: I feel default* properties need to 
be removed from ConnectionProperties class.

These properties will work wrong in following case:
1) user download OM
2) unarchive it
3) modifies <DB>_persistence.xml file
4) run install with --db-type <DB> key

I feel I will be better to to remove default* properties and set "real" 
properties with the data from *persistence.xml file

What do you think on this?
                
> Command line admin: added parameter "--drop", to drop database before install
> -----------------------------------------------------------------------------
>
>                 Key: OPENMEETINGS-194
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-194
>             Project: Openmeetings
>          Issue Type: Improvement
>            Reporter: Dmitry Zamula
>            Priority: Minor
>              Labels: cli, install, patch
>         Attachments: openmeetings_cli_install_drop_db.patch
>
>
> Optional parameter "--drop" allows to drop existing database before 
> Openmeetings install.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to