[
https://issues.apache.org/jira/browse/OPENMEETINGS-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269306#comment-13269306
]
George Kirkham commented on OPENMEETINGS-259:
---------------------------------------------
Sebastian, Checking through the code I was not able to find any issues, that
is I did not find any code that required further changes.
I will have admit, at this time I don't understand the below code, I assume
that it is retrieving the list of salutations, but I am not sure where in the
code it is getting only the "salutations" ? Is "em" a global object ?
public List<Salutations> getUserSalutations(long language_id) {
try {
CriteriaBuilder cb = em.getCriteriaBuilder();
CriteriaQuery<Salutations> cq =
cb.createQuery(Salutations.class);
Root<Salutations> from = cq.from(Salutations.class);
CriteriaQuery<Salutations> select = cq.select(from);
TypedQuery<Salutations> q = em.createQuery(select);
List<Salutations> ll = q.getResultList();
for (Salutations ti : ll) {
ti.setLabel(fieldmanagment.getFieldByIdAndLanguage(
ti.getFieldvalues_id(),
language_id));
}
return ll;
> English Language Text improvements
> -----------------------------------
>
> Key: OPENMEETINGS-259
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-259
> Project: Openmeetings
> Issue Type: Improvement
> Components: BuildsAndReleases
> Affects Versions: 2.0 Apache Incubator Release
> Environment: Debian,
> openmeetings-2.0.0.r1332875-01-05-2012_2320.tar.gz (Build # 54)
> Reporter: George Kirkham
> Assignee: SebastianWagner
> Priority: Minor
> Labels: english, language, text
> Fix For: 2.0 Apache Incubator Release
>
> Attachments: EnglishTextImprovements-259-complete-language1.diff,
> EnglishTextImprovements-259-complete.diff, EnglishTextImprovements-259.diff
>
>
> add a new "salutation" for the User's Title field for "Prof" (e.g. Professor)
> Fix typo in English text for 452, "choose_video_settings_info_text" from
> "No audio/video from you PC will be published, you profile picture will be
> shown" to "No audio/video from your PC will be published, your profile
> picture will be shown"
> change the English text for 1312, "upload file explorer", from "Do directly
> load to whiteboard" to "Load directly to the Whiteboard".
> Fix text in English text for 1315, "recording flag", from "Do not forget
> start recording. One user per room always needs to start it to have the
> recording afterwards." To "Do not forget to 'Start recording', if you want
> have the meeting recorded."
> Suggest changing English text for 1462, "file explorer" from " You need
> moderation or the right to draw on whiteboard to upload, add, delete or load
> files and folders." To "You need to be a Moderator or have the 'draw on
> whiteboard' rights to upload, add, delete or load files and folders."
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
