Hi German,

you just replicated two method calls:

public Boolean setCanGiveAudio(String SID, String publicSID, boolean
canGiveAudio)
and additionally now:
public void setCanGiveAudio(RoomClient rcl, boolean canGiveAudio)

Why is:
public void setCanGiveAudio(RoomClient rcl, boolean canGiveAudio)
a public method ? I guess no SWF-lient is able to pass a RoomClient
Object to that method, so its usage is only internal.
So that method can be even private ... remember: ALL methods that are
public in the Service classes are world-wide accessible. Anybody with
some wireshark experience could sit down and play passing params to
those methods to see what happens.

If you make a new method please use a new name instead of just
rotating the params. Function overloading is a sometimes a desired
thing but if there is no need to do it, it just makes things complex
where there is no need to.

Thanks,
Sebastian

-- 
Sebastian Wagner
http://www.openmeetings.de
http://incubator.apache.org/openmeetings/
http://www.webbase-design.de
http://www.wagner-sebastian.com
[email protected]

Reply via email to