I have reverted the ugly HashMap in favor of UploadInfo helper class seems to be more straightforward
On Wed, Mar 7, 2012 at 00:49, Maxim Solodovnik <[email protected]> wrote: > great > I'll fix junit tests and will take a look at it. > I like your code: never use Class.cast before > > > On Wed, Mar 7, 2012 at 00:46, [email protected] <[email protected] > > wrote: > >> Ok. I've also set the isAvClient to false in the methods I described, it >> might be worth trying out. >> >> >> Sebastian >> >> 2012/3/6 Maxim Solodovnik <[email protected]> >> >>> Just built everything successfully >>> >>> java version "1.6.0_29" >>> Java(TM) SE Runtime Environment (build 1.6.0_29-b11) >>> Java HotSpot(TM) 64-Bit Server VM (build 20.4-b02, mixed mode) >>> >>> ant 1.8.2 >>> >>> sure please check it in >>> >>> On Wed, Mar 7, 2012 at 00:31, Maxim Solodovnik <[email protected]>wrote: >>> >>>> OK I'll check as soon as google SVN will up >>>> >>>> the code of ClientListManager.getClientByPublicSID method will return >>>> null if isAVclient is null: >>>> if (rcl.getIsAVClient() == null || rcl.getIsAVClient() != isAVClient) >>>> { >>>> continue; >>>> } >>>> >>>> >>>> On Wed, Mar 7, 2012 at 00:27, [email protected] < >>>> [email protected]> wrote: >>>> >>>>> actually it should be null not true. >>>>> I think this might be a bug, the value might not be set, I only have >>>>> fixed it inside the conference room. >>>>> >>>>> You can see all session variables of all connected users now in the >>>>> Administration > Connections UI when you click on any connection. >>>>> >>>>> >>>>> Sebastian >>>>> >>>>> 2012/3/6 Maxim Solodovnik <[email protected]> >>>>> >>>>>> OK >>>>>> I'll add error catching to avoid errors displayed to the client. >>>>>> (It's strange but in all upload dialogs outside the room isAVClient is >>>>>> true, and message sending after upload throws Exception ...) >>>>>> >>>>>> >>>>>> On Wed, Mar 7, 2012 at 00:13, [email protected] < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Users where isAVClient==true means that this connection does not >>>>>>> handle push messages from the Red5 server. So sending to this >>>>>>> connection or >>>>>>> RoomClient will have no effect. >>>>>>> >>>>>>> Sebastian >>>>>>> >>>>>>> >>>>>>> 2012/3/6 Maxim Solodovnik <[email protected]> >>>>>>> >>>>>>>> Hello Sebastian, >>>>>>>> >>>>>>>> I've just commited refactored upload. >>>>>>>> Unfortunatelly if throws exception: >>>>>>>> >>>>>>>> java.lang.Exception: Could not Find RoomClient on List publicSID: >>>>>>>> 415408aa498aa20e2d840069e2e7fae5 >>>>>>>> at >>>>>>>> org.openmeetings.app.remote.red5.ScopeApplicationAdapter.sendMessageWithClientByPublicSID(ScopeApplicationAdapter.java:2473) >>>>>>>> ~[openmeetings.jar:na] >>>>>>>> >>>>>>>> The roomClient is present in the map, but it is marked as AV, but >>>>>>>> sent message requires NOT AV client. >>>>>>>> can I just add code to send the message regardless AV status? >>>>>>>> Or it will break something? >>>>>>>> >>>>>>>> -- >>>>>>>> WBR >>>>>>>> Maxim aka solomax >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Sebastian Wagner >>>>>>> http://www.openmeetings.de >>>>>>> http://incubator.apache.org/openmeetings/ >>>>>>> http://www.webbase-design.de >>>>>>> http://www.wagner-sebastian.com >>>>>>> [email protected] >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> WBR >>>>>> Maxim aka solomax >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Sebastian Wagner >>>>> http://www.openmeetings.de >>>>> http://incubator.apache.org/openmeetings/ >>>>> http://www.webbase-design.de >>>>> http://www.wagner-sebastian.com >>>>> [email protected] >>>>> >>>> >>>> >>>> >>>> -- >>>> WBR >>>> Maxim aka solomax >>>> >>> >>> >>> >>> -- >>> WBR >>> Maxim aka solomax >>> >> >> >> >> -- >> Sebastian Wagner >> http://www.openmeetings.de >> http://incubator.apache.org/openmeetings/ >> http://www.webbase-design.de >> http://www.wagner-sebastian.com >> [email protected] >> > > > > -- > WBR > Maxim aka solomax > -- WBR Maxim aka solomax
