done please see revision 1329175. On Mon, Apr 23, 2012 at 17:47, Maxim Solodovnik <[email protected]>wrote:
> OK, let it be this way > > > On Mon, Apr 23, 2012 at 17:42, [email protected] < > [email protected]> wrote: > >> What happens if you find a timezone with your method that has no >> mapping in om_timezones? Java knows roughly 629 timezones. We only >> have roughly 30. We cover 80% but I skipped a lot, for example for >> small Islands in the Pacific that have their own timezone but nobody >> living there. Or hundrets of duplicates like Europe/Berlin, >> Europe/Amsterdam, ... >> Also how do you map for example somebody that gives you as timezone >> GMT+1 ? There is GMT+1 Summer Daylight Time >> (Germany/France/Netherlands) and None Summer Daylight time >> (Tunesia/Algerien). You simply can't know what timezone somebody wants >> if you just have the String "GMT+1". >> >> I think you should no put too much time into it, you could also simply >> add all available options that we currently support. >> I would simply list the timezone options available in the installer >> and then give an appropriate error message in the feedback if somebody >> picks a timezone that we currently do not support. >> >> Sebastian >> >> 2012/4/23 Maxim Solodovnik <[email protected]>: >> > I definitely can, but >> > 1) while installing OM admin is not required to know which timezones we >> have >> > in our file. >> > 2) our current mechanism is not very user friendly i.e. if user make a >> > mistake in timezone name - default user will have no time zone. >> > >> > My idea was to search in java timezone name/id (which is much wider, has >> > more than 30 records), and then map java timezone found with OM >> timezon, and >> > get warning/error in case no tz with provided name was found. >> > >> > What do you think on this? >> > >> > >> > On Mon, Apr 23, 2012 at 14:00, [email protected] < >> [email protected]> >> > wrote: >> >> >> >> You can change your query to query for the column ical instead. >> >> I designed the table om_timezones that way that the column ical is >> unique. >> >> >> >> Sebastian >> >> >> >> 2012/4/23 Maxim Solodovnik <[email protected]>: >> >> > Can you please advise me what is the best way of handling user input >> for >> >> > timezone? >> >> > The way I have implemented in cli-admin was: >> >> > user enters GMT+2 or GMT-1 and gets the timezone. >> >> > >> >> > I can implement search in java timezones, and then try to map java >> >> > timezone >> >> > with OM timezone. >> >> > In this case user can enter Berlin as timezone. >> >> > >> >> > What do you think? >> >> > >> >> > >> >> > On Mon, Apr 23, 2012 at 10:31, Maxim Solodovnik < >> [email protected]> >> >> > wrote: >> >> >> >> >> >> Hello Sebastian, >> >> >> I used it for Cl Admin only, I'll revert my change back and will >> >> >> correct >> >> >> the code in Admin to get timezone and do not affect other code. >> >> >> >> >> >> >> >> >> On Fri, Apr 20, 2012 at 20:13, [email protected] >> >> >> <[email protected]> wrote: >> >> >>> >> >> >>> Hi Maxim, >> >> >>> >> >> >>> do you remember where exactly you are using the GMT+1% query? >> >> >>> >> >> >>> Cause we have a problem that will start soon to get annoying: >> >> >>> There will be multiple GMT+1 for example, cause there is >> >> >>> GMT+1 Summer Daylight Time Europe/Berlin >> >> >>> GMT+1 (No Summer Daylight Time) Africe/Tunis for example >> >> >>> >> >> >>> There will be the same problem with other timezones. >> >> >>> Where are you currently using this query, is it only the installer >> at >> >> >>> the moment or are there other components using it too? >> >> >>> >> >> >>> Thanks! >> >> >>> Sebastian >> >> >>> -- >> >> >>> Sebastian Wagner >> >> >>> https://twitter.com/#!/dead_lock >> >> >>> http://www.openmeetings.de >> >> >>> http://www.webbase-design.de >> >> >>> http://www.wagner-sebastian.com >> >> >>> [email protected] >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> WBR >> >> >> Maxim aka solomax >> >> > >> >> > >> >> > >> >> > >> >> > -- >> >> > WBR >> >> > Maxim aka solomax >> >> >> >> >> >> >> >> -- >> >> Sebastian Wagner >> >> https://twitter.com/#!/dead_lock >> >> http://www.openmeetings.de >> >> http://www.webbase-design.de >> >> http://www.wagner-sebastian.com >> >> [email protected] >> > >> > >> > >> > >> > -- >> > WBR >> > Maxim aka solomax >> >> >> >> -- >> Sebastian Wagner >> https://twitter.com/#!/dead_lock >> http://www.openmeetings.de >> http://www.webbase-design.de >> http://www.wagner-sebastian.com >> [email protected] >> > > > > -- > WBR > Maxim aka solomax > -- WBR Maxim aka solomax
