I guess it should be considered as WAD. I can add try/catch to "swallow" the exception, but I better leave it as it is. It is up to admin fix the wrong commanline option he/she provided and run the tool 1 more time
2012/4/25 [email protected] <[email protected]> > Great! > > I was facing a minor issue with the --drop > If the database does not exist yet at all the --drop throws some > exception (as there is nothing to drop I guess) > > Sebastian > > 2012/4/25 Maxim Solodovnik <[email protected]>: > > OK, here is commands to demonstrate my solution: > > > > admin -b > > will backup OM and create backup_25_04_2012_17_14_26.zip > > > > admin -i -v -file backup_25_04_2012_17_14_26.zip --db-type mysql > --db-host > > 192.168.72.105 --drop --skip-default-rooms > > will install OM using backup specified AND > > 1) --db-type mysql - set DB type to be MySQL > > 2) --db-host 192.168.72.105 - set DB host to be different from localhost > > 3) --drop - drop existent database > > 4) --skip-default-rooms - do not create default rooms to avoid rooms > with > > duplicate names > > > > Going to commit this functionality > > > > 2012/4/25 [email protected] <[email protected]> > > > >> Yes that is also a problem, I think the proposal with the CLI to skip > >> users/organization is still useful, however it will not fix your issue > >> and for users that want to import via the Web-Frontend skipping users > >> during install is no option. > >> > >> We could additionally either rename the existing user if there is > >> already a user existing that has the same login. > >> Or you do a check before you start the import and throw an Error > >> message to the user: "fix duplicated username" before the import > >> starts. > >> A cleaner approach would be the error message, but also a more > >> CPU/Memory consuming: You will have to parse the whole XML before you > >> save anything, just to check for duplicates. And then you will need to > >> eventually parse it again for the real import. > >> > >> But I would suggest to not manipulate imported data or skip anything > >> in the data, that just leads to a lot of questions from users that > >> will wonder why some records of the import do not get imported. > >> I also think renaming existing data auto-magically is no good idea, if > >> there is an error there should be an error text with some instructions > >> on how to correct this and no manipulation. > >> > >> Sebastian > >> > >> 2012/4/25 Alexei Fedotov <[email protected]>: > >> > Here is a scenario I want to avoid: > >> > > >> > 1) someone re-installs OM; > >> > 2) he enters password during installation process; > >> > 3) he imports data, now installation has two admins; > >> > 4) he restarts the system; > >> > 4) login no longer works. > >> > > >> > > >> > > >> > 2012/4/25 [email protected] <[email protected]>: > >> >> Yes, > >> >> > >> >> I would also vote for Maxim's proposal. Otherwise we need to do some > >> >> obscure actions in the importer to skip certain objects from > importing > >> >> depending on the userId that is connected to it. > >> >> > >> >> Sebastian > >> >> > >> >> 2012/4/25 Maxim Solodovnik <[email protected]>: > >> >>> How can we separate "superadministrator" from any "administrator" ? > >> >>> Are you sure you want to skip importing admin user with all his/her > >> events > >> >>> groups etc.? > >> >>> > >> >>> On Wed, Apr 25, 2012 at 15:32, Alexei Fedotov < > >> [email protected]>wrote: > >> >>> > >> >>>> The only existing user was superadministrator. We may skip > importing > >> >>>> superadministrator, if one already exists. > >> >>>> 25.04.2012 11:54 пользователь "[email protected]" < > >> >>>> [email protected]> > >> >>>> написал: > >> >>>> > >> >>>> > Hi Alexei, > >> >>>> > > >> >>>> > about your missing rooms: > >> >>>> > It is likely that there was some NullPointerException due to a > >> missing > >> >>>> > attribute in the XML either while exporting or while importing. > >> >>>> > It can also happen that somehow a NON UTF8 character somehow is > >> >>>> > exported into the XML (however I have no idea how anybody > achieves > >> to > >> >>>> > write Non UTF8 chars into a UTF8 encoded database). > >> >>>> > If that is the case you also have an exception in the log, you > >> should > >> >>>> > then unpack the ZIP fix the character in the XML and pack it > again. > >> >>>> > > >> >>>> > For the duplicated admin account I have no idea yet, the only > chance > >> >>>> > would be to delete all existing users (not only flag deleted = > true > >> >>>> > but really remove) whenever you do an import. > >> >>>> > What do you think shall we do that? > >> >>>> > > >> >>>> > Sebastian > >> >>>> > > >> >>>> > 2012/4/25 Alexei Fedotov <[email protected]>: > >> >>>> > > Localization > >> >>>> > > 1. Russian localization again doesn't fit new buttons - should > use > >> >>>> icons > >> >>>> > + > >> >>>> > > tooltips for text. > >> >>>> > > 2. New explanatory menu items are not localized. > >> >>>> > > > >> >>>> > > Export/Import > >> >>>> > > 1. The client customizes rooms for his business process. It > seems > >> that > >> >>>> > room > >> >>>> > > list is not exported / imported. > >> >>>> > > 2. After import I get two admin accounts. I've proactively > >> deleted one. > >> >>>> > > Nick experienced login problems, maybe due to the second > account. > >> >>>> > > 3. Mail settings should be imported/exported. > >> >>>> > > > >> >>>> > > Otherwise upgrading release is a piece of cake. Thank you, > >> Sebastian, > >> >>>> > Maxim > >> >>>> > > and all who contributed their code. > >> >>>> > > >> >>>> > > >> >>>> > > >> >>>> > -- > >> >>>> > Sebastian Wagner > >> >>>> > https://twitter.com/#!/dead_lock > >> >>>> > http://www.openmeetings.de > >> >>>> > http://www.webbase-design.de > >> >>>> > http://www.wagner-sebastian.com > >> >>>> > [email protected] > >> >>>> > > >> >>>> > >> >>> > >> >>> > >> >>> > >> >>> -- > >> >>> WBR > >> >>> Maxim aka solomax > >> >> > >> >> > >> >> > >> >> -- > >> >> Sebastian Wagner > >> >> https://twitter.com/#!/dead_lock > >> >> http://www.openmeetings.de > >> >> http://www.webbase-design.de > >> >> http://www.wagner-sebastian.com > >> >> [email protected] > >> > >> > >> > >> -- > >> Sebastian Wagner > >> https://twitter.com/#!/dead_lock > >> http://www.openmeetings.de > >> http://www.webbase-design.de > >> http://www.wagner-sebastian.com > >> [email protected] > >> > > > > > > > > -- > > WBR > > Maxim aka solomax > > > > -- > Sebastian Wagner > https://twitter.com/#!/dead_lock > http://www.openmeetings.de > http://www.webbase-design.de > http://www.wagner-sebastian.com > [email protected] > -- WBR Maxim aka solomax
