I mean in the code we have something like:
if (user_id < 0) {
return -11;
}
And It is not very self descriptive
The code like
if (user_id < 0) {
return INVALID_CREDENTIALS;
}
are easier to read.
On Thu, May 24, 2012 at 3:18 PM, [email protected] <
[email protected]> wrote:
> The errors are already in a XML file.
>
> https://svn.apache.org/repos/asf/incubator/openmeetings/trunk/singlewebapp/WebContent/languages/errorvalues.xml
>
> I think having the XML file is already the optimum for storing the error
> codes. However that XML file only contains label-Id's no actual text. That
> is the issue.
>
>
> Sebastian
>
> 2012/5/24 Maxim Solodovnik <[email protected]>
>
>> I would create enum first so these codes will not be "cryptic" to the
>> developers :)
>> On May 24, 2012 2:43 PM, "[email protected]" <[email protected]>
>> wrote:
>>
>>> Btw: Those cryptic error codes are no way to confuse people :)
>>> There is an SOAP/REST call to get a localized message for every error id:
>>> http://incubator.apache.org/openmeetings/UserService.html#getErrorByCode
>>>
>>> However, I think we should generate a page in our docs that shows a list
>>> with the errors in a table.
>>> I will look at a way how we can generate this website, similar to the
>>> way the SOAP/REST API Reference is generated.
>>>
>>> Sebastian
>>>
>>> 2012/5/24 Maxim Solodovnik <[email protected]>
>>>
>>>> I think
>>>> sorry
>>>>
>>>>
>>>> On Thu, May 24, 2012 at 9:31 AM, Maxim Solodovnik <[email protected]
>>>> > wrote:
>>>>
>>>>> I thing you need to perform steps
>>>>> 1) 2) 4) 5) for the second login
>>>>>
>>>>>
>>>>> On Thu, May 24, 2012 at 9:26 AM, madkoala ([email protected]) <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hello. I'm working on integrating OM 1.9.1 and .NET Application
>>>>>> (written in C#).
>>>>>> Almost all features are working well, but there's a serious problem.
>>>>>>
>>>>>> Once I logged in, I can enter conference room successfully.
>>>>>> But, after then, I can't move to another conference room.
>>>>>> setUserObjectAndGenerateRoomHashByURL returns -26 (Admin
>>>>>> authorization required).
>>>>>>
>>>>>> Here's my scenario.
>>>>>>
>>>>>> 1. call omUser.getSession();
>>>>>> 2. call omUser.loginUser(omSession.session_id, 'admin', 'password',
>>>>>> out retval, out retvalSpecified); → 'admin' has administrator's
>>>>>> rights in OM.
>>>>>> 3. call omRoom.getRoomsPublic(omSession.session_id, 1, true); → this
>>>>>> returns list of public conference rooms successfully.
>>>>>> 4. call string roomHash =
>>>>>> omUser.setUserObjectAndGenerateRoomHashByURL(omSession.session_id,
>>>>>> "madkoala", "my", "name", string.Empty,
>>>>>> "[email protected]"<[email protected]>,
>>>>>> 10, true, "my external system", room.rooms_id.Value, true, 0, true, 1,
>>>>>> true);
>>>>>> → 'madkoala' is my external system id (doesn't exists in OM now)
>>>>>> 5. I can access conference room with that room hash. (
>>>>>> http://myhost/openmeetings/?secureHash=roomHash)
>>>>>> 6. When I try to join another conference room with same procedure 4-5
>>>>>> above, setUserObjectAndGenerateRoomHashByURL returns -26.
>>>>>> 7. Only after changing user type of 'madkoala' in OM to
>>>>>> administrator, it works well.
>>>>>>
>>>>>> So, here's my question.
>>>>>> 1. Are there any way to change user rights to administrator
>>>>>> programmatically using SOAP?
>>>>>> 2. Are the procedures above correctly implemented?
>>>>>> 3. Is there a way to make it work (moving to another conference room)
>>>>>> without changing user type?
>>>>>>
>>>>>> Thank you in advance.
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> WBR
>>>>> Maxim aka solomax
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> WBR
>>>> Maxim aka solomax
>>>>
>>>
>>>
>>>
>>> --
>>> Sebastian Wagner
>>> https://twitter.com/#!/dead_lock
>>> http://www.openmeetings.de
>>> http://www.webbase-design.de
>>> http://www.wagner-sebastian.com
>>> [email protected]
>>>
>>
>
>
> --
> Sebastian Wagner
> https://twitter.com/#!/dead_lock
> http://www.openmeetings.de
> http://www.webbase-design.de
> http://www.wagner-sebastian.com
> [email protected]
>
--
WBR
Maxim aka solomax