On Tue, 2008-03-04 at 18:11 +0800, Chia-I Wu wrote: > Hi Chris, > > This patch adds support for phonebook import from the SIM card. The > import process is manual. I add a toolbar button to the details page > for it. > > Ideally, we don't need a button. The import process should be > automatic, and happen before the UI (in phonekit?). But to go > automatic, openmoko-contacts needs to be at least phonebook-aware first. > Otherwise, confusions arise, as discussed in this thread, > > http://lists.openmoko.org/pipermail/openmoko-devel/2008-February/002014.html > > The place I chose for the import button is also, well, quite random. A > better place (and a better icon) for the button might be needed.
Nice work (although patch isn't attached, apparently :)) - I'd suggest that this be made into a small stand-alone utility application though. Having an extra button that you'll likely only want to use once, if ever, seems overkill. Even better would be an addition to phone-kit to synchronise phonebook entries with EBook entries - this could be done by setting a custom property, say X-MOKO-PBENTRY, that contains a reference to the phonebook entry, then checking for this property on the contacts-modified/contacts-removed signals and synchronising accordingly. phone-kit would need to check through all contacts on start-up to see which SIM contacts have EBook partners, and add/alter/remove when there is any inconsistency. This could just be done in contacts as well of course, but phone-kit is always running and other clients may have reason to change contact details. I suggest whatever you do, you file a bug about this ,if there isn't already one, and attach this and any future patches. Regards, --Chris
