Thanks for your comments,
and I followed your instruction except the following 2 parts.

configuration specific bits in platform code is never very good.
I belive working index could have removed by using the nr_chips field.
Sorry, I don't have idea for that, could you provide some concrete source codes?

Secondly, why did the hardware engineers make 3 copies of what is
an open-collector signal, in a system where the nand controller
can only access one chip at a time? RnB should have been common
to all three chips.

Our hardware engineers designed this, and it seems not possible to change it now.
So this part of  driver is not changed.

Regards,
--
Eric


----- Original Message ----- From: "Ben Dooks" <[EMAIL PROTECTED]>
To: "Eric Chen" <[EMAIL PROTECTED]>
Cc: <[email protected]>
Sent: Friday, May 18, 2007 6:55 PM
Subject: Re: [PATCH]hxd8-nand-chip-select.patch


On Fri, May 18, 2007 at 03:54:14PM +0800, Eric Chen wrote:
Log:
This nand chip-select patch for HXD8, support up to 4G nand flash.

Patches included in-line are much easier to review. Patch
can generally deal with any extra text, so this also means
we can keep a description with the patch.

I will review the content of this patch fully later.

--
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

Attachment: hxd8-nand-chip-select.patch
Description: Binary data

Reply via email to