On Sun, Feb 10, 2008 at 09:11:16PM -0300, Werner Almesberger wrote: > Andy Green wrote: > > + if (__reg_read(pcf, PCF50633_REG_MBCS1) & > > + (PCF50633_MBCS1_USBPRES | PCF50633_MBCS1_USBOK) == > > Gotcha ! ;-) > > Applied in revision 4045, with parentheses added. > > I had a quick look at the discussion, and it seems that this patch > may change in the future, so I left it as a separate patch for now, > instead of merging it into pcf50633.patch
No, I think this patch is pretty fine, it fixes one of two separate bugs. As long as USB power is provided, you never want to send SIGPWR. The pcf50606 driver needs a similar fix. The pcf50606 also needs the fix for sending an input event in case USB power is already connected at bootup (we don't send events based on iniital state). -- - Harald Welte <[EMAIL PROTECTED]> http://openmoko.org/ ============================================================================ Software for the world's first truly open Free Software mobile phone
