matt_hsu wrote: > This patch is provided with the folloing, Thanks !
I think GTA02_GPIO_nDL_GSM should only be set if we're on machine_is_neo1973_gta02, correct ? (GTA01 doesn't even have a GPJ6 pin.) > # remove AUX key as wake up source. Ah, let me guess why you did this: - your NOR is empty/undefined - you hit AUX to resume - since AUX is pressed, we boot from NOR - nothing there, so not much happens (We just chatted and my guess was right ;-) This problem will actually go away when we put u-boot into NOR, since the resume code will be the same. However, I think it's good to overload AUX a little less. And just using POWER to resume seems a lot more intuitive than having AUX as well. I wonder if we don't want to do this for GTA01 as well. Does anyone see a reason why we shouldn't do this ? (Except perhaps for the little bit of user confusion this may cause ?) Applied in revisions 4089 and 4090. - Werner
