Hi Werner,

Currently, the battery indication is not correct on Neo. It can be fixed
to apply the following changes. 

# Attached patch 

# Disable CONFIG_APM_POWER 
        Since this configuration would let apm_get_power_status is registered
to apm_battery_apm_get_power_status(). But it should be registered to
pcf50633_get_power_status.

Still, the bug #255 can't be close. Because the support for HDQ battery
is not integrated with battery indication. I'll try to finish this and
send you a patch later. Once it's done, we can close this bug. 

Cheers,

Matt
Index: linux-2.6.24/drivers/i2c/chips/pcf50633.c
===================================================================
--- linux-2.6.24.orig/drivers/i2c/chips/pcf50633.c	2008-03-03 13:22:11.000000000 +0800
+++ linux-2.6.24/drivers/i2c/chips/pcf50633.c	2008-03-03 17:33:48.000000000 +0800
@@ -1199,8 +1199,8 @@
         struct pcf50633_data *pcf = pcf50633_global;
 	u_int8_t chgmod = reg_read(pcf, PCF50633_REG_MBCS2) &
 				   PCF50633_MBCS2_MBC_MASK;
-	u_int16_t battvolt = 0; /* FIXME */
-	//u_int16_t battvolt = pcf50606_battvolt(pcf);
+
+	u_int16_t battvolt = pcf50633_battvolt(pcf);
 
 	if (reg_read(pcf, PCF50633_REG_MBCS1) &
 			(PCF50633_MBCS1_USBPRES|PCF50633_MBCS1_ADAPTPRES))
@@ -1209,6 +1209,7 @@
 		info->ac_line_status = APM_AC_OFFLINE;
 
 	switch (chgmod) {
+	case PCF50633_MBCS2_MBC_PLAY:
 	case PCF50633_MBCS2_MBC_USB_PRE:
 	case PCF50633_MBCS2_MBC_USB_PRE_WAIT:
 	case PCF50633_MBCS2_MBC_USB_FAST_WAIT:

Reply via email to