Begin forwarded message:
From: Werner Almesberger <[EMAIL PROTECTED]>
Date: April 16, 2008 9:55:30 PM GMT+08:00
To: Andy Green <[EMAIL PROTECTED]>
Cc: gta02 <[EMAIL PROTECTED]>
Subject: Re: [gta02] u-boot boot menu regression ?

Andy Green wrote:
Just a thought, maybe you can change this to act like that if there was
no valid environment in NAND, that might meet the request and be a
reasonable behaviour for users too, without having special modified
builds for factory.

Like this ? I kind of doubt this solves Miles' problem, though.
All you get is the boot menu that offers you "Boot", which of
course doesn't work, since you don't have the partition table.

ObWolfgang: the reason why I'm not sending this patch to the
 public list is that it's probably useless and I don't even
 think I understand where in the factory the problem is. In
 case that patch should turn out to be useful, I'll be happy
 to repost it ;-)

Cheers, Werner
Index: u-boot/board/neo1973/gta02/gta02.c
===================================================================
--- u-boot.orig/board/neo1973/gta02/gta02.c
+++ u-boot/board/neo1973/gta02/gta02.c
@@ -73,6 +73,7 @@
 extern unsigned char booted_from_nor;
 extern int nobootdelay;
 char __cfg_prompt[20] = "GTA02vXX # ";
+int enter_bootmenu = 0;
 
 /*
  * In >GTA02v5, use gta02_revision to test for features, not
@@ -352,7 +353,6 @@
        char buf[32];
        int menu_vote = 0; /* <= 0: no, > 0: yes */
        int seconds = 0;
-       int enter_bootmenu;
 
        set_revision();
 
@@ -431,7 +431,8 @@
        neo1973_poweroff();
 
 continue_boot:
-       enter_bootmenu = menu_vote > 0 || booted_from_nor;
+       if (menu_vote > 0 || booted_from_nor)
+               enter_bootmenu = 1;
        smedia3362_lcm_reset(1);
        if (!enter_bootmenu && getenv("splashimage"))
                run_command(getenv("splashimage"), 0);
Index: u-boot/common/env_nand.c
===================================================================
--- u-boot.orig/common/env_nand.c
+++ u-boot/common/env_nand.c
@@ -312,8 +312,11 @@
 #if !defined(ENV_IS_EMBEDDED)
 static void use_default()
 {
+       extern int enter_bootmenu;
+
        puts ("*** Warning - bad CRC or NAND, using default environment\n\n");
        default_env();
+       enter_bootmenu = 1;
 }
 #endif
 
_______________________________________________
gta02 mailing list
[EMAIL PROTECTED]
https://lists.internal.openmoko.org/mailman/listinfo/gta02

Reply via email to